ashpie/swaf
1
0
Fork 0
Code Issues 22 Pull Requests Releases 11 Wiki Activity

Fix chmod check and relax mail

Browse Source
This commit is contained in:
Alice Gaudon 2020-07-15 15:39:08 +02:00
parent 583a5a92de
commit e9a20c82ed
3 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -1,6 +1,6 @@
{ {
"name": "wms-core", "name": "wms-core",
"version": "0.16.1", "version": "0.16.3",
"description": "Node web framework", "description": "Node web framework",
"repository": "git@gitlab.com:ArisuOngaku/wms-core.git", "repository": "git@gitlab.com:ArisuOngaku/wms-core.git",
"author": "Alice Gaudon <alice@gaudon.pro>", "author": "Alice Gaudon <alice@gaudon.pro>",

8
src/Application.ts
View File

@ -186,9 +186,11 @@ export default abstract class Application {
const fullPath = path.resolve(configDir, file); const fullPath = path.resolve(configDir, file);
const stats = fs.lstatSync(fullPath); const stats = fs.lstatSync(fullPath);
if (stats.uid !== process.getuid()) if (stats.uid !== process.getuid())
throw new SecurityError(fullPath + ' is not owned by this process (' + process.getuid() + ').'); throw new SecurityError(`${fullPath} is not owned by this process (${process.getuid()}).`);
if (stats.mode !== 400)
throw new SecurityError(fullPath + ' is not chmod 400.'); const mode = (stats.mode & parseInt('777', 8)).toString(8);
if (mode !== '400')
throw new SecurityError(`${fullPath} is ${mode}; should be 400.`);
} }
// Check security fields // Check security fields

6
src/components/MailComponent.ts
View File

@ -8,9 +8,9 @@ export default class MailComponent extends ApplicationComponent<void> {
public async checkSecuritySettings(): Promise<void> { public async checkSecuritySettings(): Promise<void> {
if (!config.get<boolean>('mail.secure')) { // if (!config.get<boolean>('mail.secure')) {
throw new SecurityError('Cannot set mail.secure to false'); // throw new SecurityError('Cannot set mail.secure to false');
} // }
if (config.get<boolean>('mail.allow_invalid_tls')) { if (config.get<boolean>('mail.allow_invalid_tls')) {
throw new SecurityError('Cannot set mail.allow_invalid_tls to true'); throw new SecurityError('Cannot set mail.allow_invalid_tls to true');
} }