From 15678e03813a5d00ee5234e459309685756ebfe7 Mon Sep 17 00:00:00 2001 From: Alice Gaudon Date: Thu, 10 Sep 2020 19:11:32 +0200 Subject: [PATCH] Fix relation reducing mistakenly using "in" instead of indexOf >= 0 --- src/db/ModelRelation.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/db/ModelRelation.ts b/src/db/ModelRelation.ts index 6a1c54b..71f68fc 100644 --- a/src/db/ModelRelation.ts +++ b/src/db/ModelRelation.ts @@ -72,7 +72,7 @@ export default abstract class ModelRelation[], subRelations: string[] = []): Promise> { const ids = relations.map(r => r.getModelID()) .filter(id => id !== null && id !== undefined) - .reduce((array: O[], val) => val in array ? array : [...array, val], []); + .reduce((array: O[], val) => array.indexOf(val) >= 0 ? array : [...array, val], []); if (ids.length === 0) return []; const query = this.makeQuery(); @@ -181,7 +181,7 @@ export class ManyThroughModelRelation extends public async eagerLoad(relations: ModelRelation[], subRelations: string[] = []): Promise> { const ids = relations.map(r => r.getModelID()) - .reduce((array: O[], val) => val in array ? array : [...array, val], []); + .reduce((array: O[], val) => array.indexOf(val) >= 0 ? array : [...array, val], []); if (ids.length === 0) return []; const query = this.makeQuery();