Fixed battery widget opening missing file #1

lucastarche · 2021-07-03T21:49:46+02:00

lucastarche commented

2021-07-03 21:49:46 +02:00

Some models of batteries (like mine, hence this PR), have no files named "energy_now" nor "energy_full", but do have "charge_now" and "charge_full".

It adds a check to see whether the file exists or not, and uses the appropiate files

It should work but as I have no way to check if it works with batteries with "energy_now"

Some models of batteries (like mine, hence this PR), have no files named "energy_now" nor "energy_full", but do have "charge_now" and "charge_full". It adds a check to see whether the file exists or not, and uses the appropiate files It *should* work but as I have no way to check if it works with batteries with "energy_now"

lucastarche added 1 commit 2021-07-03 21:49:46 +02:00

7ed0fc7522 Fixed battery widget opening missing file

ashpie commented

2021-07-04 12:45:53 +02:00

Hi, thanks a lot for this pull request. Do you mind to instead of using the cat shell command, add and use this function? :

function file_exists(name)
	local f = io.open(name,"r")
	if f ~= nil then
		io.close(f)
		return true
	else
		return false
	end
end

You don't have to replace everything in this file, I think it'd just be a better practice to try and use the io library asap.

Hi, thanks a lot for this pull request. Do you mind to instead of using the `cat` shell command, add and use this function? : ```lua function file_exists(name) local f = io.open(name,"r") if f ~= nil then io.close(f) return true else return false end end ``` You don't have to replace everything in this file, I think it'd just be a better practice to try and use the io library asap.

lucastarche added 1 commit 2021-07-04 15:12:03 +02:00

16772da504 Added `fileExists()`

lucastarche commented

2021-07-04 15:13:56 +02:00

This should implement the changes, although do tell me if you need me to change something else.